Skip to content

Add steven as maintainer for UX#1634

Merged
istio-testing merged 4 commits intoistio:masterfrom
Stevenjin8:steven-networking
Jul 16, 2025
Merged

Add steven as maintainer for UX#1634
istio-testing merged 4 commits intoistio:masterfrom
Stevenjin8:steven-networking

Conversation

@Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Jul 3, 2025 •
edited
Loading

Hey folks, reopening #1548.
Last time, I got feedback that I wasn't reviewing enough PRs/involved enough in the community.

I believe I've addressed this:

I realize that these aren't specific, so here are some networking related PRs that I've been involved for networking:

Here are UX related ones:

And for ztunnel:

Please let me know if you have any feedback

I want to join the Istio org!

@Stevenjin8 Stevenjin8 requested a review from a team as a code owner July 3, 2025 17:24
@istio-testing istio-testing added needs-rebase size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025
@Stevenjin8 Stevenjin8 changed the title Add steven as networking maintainer Add steven asmaintainer Jul 3, 2025
@Stevenjin8 Stevenjin8 changed the title Add steven asmaintainer Add steven as maintainer Jul 3, 2025
@Stevenjin8 Stevenjin8 changed the title Add steven as maintainer Add steven as maintainer for Networking, Ztunnel, and UX Jul 3, 2025
@craigbox
Copy link
Contributor

craigbox commented Jul 3, 2025

♥️

@keithmattix
Copy link
Contributor

keithmattix commented Jul 7, 2025

Tagging relevant maintainers/WG leads: @therealmitchconnors @howardjohn @Stevenjin8 @ramaraochavali

@Stevenjin8 Stevenjin8 force-pushed the steven-networking branch from f5bebd3 to a8c72ac Compare July 7, 2025 16:10
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2025
therealmitchconnors
therealmitchconnors previously approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@therealmitchconnors therealmitchconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for UX!

@zirain
Copy link
Member

zirain commented Jul 8, 2025 •
edited
Loading

I think we should take it step by step, becoming a UX maintainer first is a good start.

+1 for UX.

@ramaraochavali
Copy link
Contributor

ramaraochavali commented Jul 9, 2025 •
edited
Loading

+1 to what @zirain said. Prefer to go 1 step at time.

@hzxuzhonghu 's input also

@keithmattix
Copy link
Contributor

keithmattix commented Jul 9, 2025

Fair point about one area at a time. That being said, it seems like networking would be more appropriate based on the PRs and reviews no (I'm looking at #1548 plus this PR as well)

@Stevenjin8
Copy link
Contributor Author

Stevenjin8 commented Jul 9, 2025

@zirain @ramaraochavali Thanks for your feedback. I'm curious if there is anything you would look for specifically when it comes to networking/ztunnel? I feel like I have a good number of contributions and reviews. Do I have to just do more? Be more active in issues?

@ramaraochavali
Copy link
Contributor

ramaraochavali commented Jul 9, 2025

. Do I have to just do more? Be more active in issues?

Yes. I think you are on the right track for networking. Ztunnel - I am not fully following. So @keithmattix or @howardjohn can comment.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2025
@Stevenjin8
Copy link
Contributor Author

Stevenjin8 commented Jul 11, 2025

Thanks for the feedback, I've updated the PR to be just UX

@Stevenjin8 Stevenjin8 changed the title Add steven as maintainer for Networking, Ztunnel, and UX Add steven as maintainer for UX Jul 11, 2025
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Jul 15, 2025

+1

zirain
zirain approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

keithmattix
keithmattix approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome Steven!

@istio-testing istio-testing merged commit 95882ae into istio:master Jul 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithmattix keithmattix keithmattix approved these changes

@zirain zirain zirain approved these changes

@therealmitchconnors therealmitchconnors therealmitchconnors left review comments

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Stevenjin8 @craigbox @keithmattix @zirain @ramaraochavali @hzxuzhonghu @therealmitchconnors @istio-testing